chore: Upgrade golang dependencies and golangci-lint#998
Open
christian-heusel wants to merge 3 commits intokubeflow:notebooks-v2from
Open
chore: Upgrade golang dependencies and golangci-lint#998christian-heusel wants to merge 3 commits intokubeflow:notebooks-v2from
christian-heusel wants to merge 3 commits intokubeflow:notebooks-v2from
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
google-oss-prow
bot
added
area/controller
christian-heusel
force-pushed
the
chore/notebooks-v2-upgrade-golang-dependencies
branch
2 times, most recently
from
fa7e46a to
1686fd4
Compare
Contributor
Author
|
/ok-to-test |
christian-heusel
added a commit
to christian-heusel/dashboard
that referenced
this pull request
Apr 9, 2026
Create a dependabot config similar to the one proposed in `kubeflow/notebooks` to reduce the overall log spam. Link: kubeflow/notebooks#998 Signed-off-by: Christian Heusel <[email protected]>
christian-heusel
force-pushed
the
chore/notebooks-v2-upgrade-golang-dependencies
branch
from
1686fd4 to
71cc18b
Compare
Signed-off-by: Christian Heusel <[email protected]>
Signed-off-by: Christian Heusel <[email protected]>
christian-heusel
force-pushed
the
chore/notebooks-v2-upgrade-golang-dependencies
branch
from
71cc18b to
0eb17f3
Compare
Fixes errors surfaced by upgrading golangci-lint from v1.61.0 to v2.11.4 (using the v2 module path). - gosec (G118): suppress false-positive in server.go where context.Background() is intentionally used for HTTP server shutdown after the parent context has already been canceled - staticcheck (QF1008): remove redundant embedded field selectors in secrets/types_write.go (s.secretBase.validateBase -> s.validateBase) - prealloc: eliminate pre-declared nil slices that are only ever grown via append, by either using direct assignment from the first function call or inline append(a, b...) for two-call patterns; also preallocate test-case slices in validation_test.go using the capacities suggested by the linter Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Signed-off-by: Christian Heusel <[email protected]>
christian-heusel
force-pushed
the
chore/notebooks-v2-upgrade-golang-dependencies
branch
from
0eb17f3 to
8e585a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Note: The reason this also includes the golangci-lint upgrade is that the old version did not build with the newer go versions)
TODO:
kubeflow/notebooks#1014)